Renewal for fixed Expiry Date 31/12 adds 24 months

giles chipperfield
Topic Author
Offline
New Member

More

10 years 5 months ago - 10 years 5 months ago #52561 by giles chipperfield

Renewal for fixed Expiry Date 31/12 adds 24 months was created by giles chipperfield

Hi,
I am testing MembershipPro v 1.6.6 before live
My memberships have a fixed expiry of 31-December each year, and then may renew for a further 12 months.
However, renewal add 24 months to the subscription.
If I set the expiry date to 30-December renewal adds 12 months corectly, so it looks liek an error with date handling.
I think this error is in ...components\com_osmembership\models\register.php line 154.
I attach evidence of tests with a 31/12 and 30/12 expiry date.
Thanks for your help
Giles

Last edit: 10 years 5 months ago by giles chipperfield.

Please Log in or Create an account to join the conversation.

Tuan Pham Ngoc
Away
Administrator

More

10 years 5 months ago #52573 by Tuan Pham Ngoc

Replied by Tuan Pham Ngoc on topic Renewal for fixed Expiry Date 31/12 adds 24 months

Hi Giles

Could you please submit a support ticket sending us super admin and FTP account of your site so that I can check it directly on your site to see what's wrong and get it corrected for you ?

Regards,

Tuan

Please Log in or Create an account to join the conversation.

giles chipperfield
Topic Author
Offline
New Member

More

10 years 5 months ago - 10 years 5 months ago #52579 by giles chipperfield

Replied by giles chipperfield on topic Renewal for fixed Expiry Date 31/12 adds 24 months

File Attachment:

File Name: Membership...rror.doc
File Size:87 KB

Hi Tuan,
I am testing this on a local system so cannot grant access.
I have decribed the problem and attached a pdf of evidence of what is happening, although I am not sure if the attachment is actually being registered on this forum.
It is not hard for you to demonstrate for yourself. In summary, if you have a fixed expiry date for a plan of 31/12/2014 then a renewal will produce a subscription for 01/01/2015 - 31/12/2016. This is clearly wrong.
Regards,
Giles

Attachments:

Last edit: 10 years 5 months ago by giles chipperfield.

Please Log in or Create an account to join the conversation.

giles chipperfield
Topic Author
Offline
New Member

More

10 years 5 months ago #52582 by giles chipperfield

Replied by giles chipperfield on topic Renewal for fixed Expiry Date 31/12 adds 24 months

Just realised that forum does not allow pdf so have uploaded evidence as a doc
The issue is that the code line 139 adds P1D (one day) to expiry date to get the start date of the new subscription, which moves it into the next calendar year.
The code later (line 154) then adds 1year to the start date year. But the start date year is already +1 since the one day was added to it....so it is now a 2-year subscription.

Please Log in or Create an account to join the conversation.

giles chipperfield
Topic Author
Offline
New Member

More

10 years 5 months ago #52884 by giles chipperfield

Replied by giles chipperfield on topic Renewal for fixed Expiry Date 31/12 adds 24 months

Bump?

Been 6 days now and my renewal date is approaching. I have to decide whether to use this software....

Thanks in advance

Giles

Please Log in or Create an account to join the conversation.

Tuan Pham Ngoc
Away
Administrator

More

10 years 5 months ago #52885 by Tuan Pham Ngoc

Replied by Tuan Pham Ngoc on topic Renewal for fixed Expiry Date 31/12 adds 24 months

Hi Giles

Been busy developing some new features of the extension and forgot to get back to this (I thought you fixed this issue yourself , so I didn't check it yet as I don't think it happens with many customers - this is a special case)

I am going to work on this issue and get it completely fixed on tomorrow.

Regards,

Tuan

Please Log in or Create an account to join the conversation.

giles chipperfield
Topic Author
Offline
New Member

More

10 years 4 months ago #53111 by giles chipperfield

Replied by giles chipperfield on topic Renewal for fixed Expiry Date 31/12 adds 24 months

Bump... again... ?

Regards,

Giles

Please Log in or Create an account to join the conversation.

Tuan Pham Ngoc
Away
Administrator

More

10 years 4 months ago #53113 by Tuan Pham Ngoc

Replied by Tuan Pham Ngoc on topic Renewal for fixed Expiry Date 31/12 adds 24 months

Sorry Giles. I completely forgot about this issue. Will work on it on tomorrow and update you with the result !

Regards,

Tuan

Please Log in or Create an account to join the conversation.

Powered by Kunena Forum

Renewal for fixed Expiry Date 31/12 adds 24 months

File Attachment:

Support

Documentation

Information

Connect Us