- Posts: 88
- Thank you received: 1
[22-March-2022] Membership Pro version 3.0.0 released
- Roger Clarke
- Offline
- Premium Member
Less
More
2 years 7 months ago #151584
by Roger Clarke
Replied by Roger Clarke on topic [22-March-2022] Membership Pro version 3.0.0 released
Hi Tuan,
Renew Membership, Subscription History, Manage Group Members - not sure how many others. Could be a generic issue as the headings would be H1 for menu items.
Thanks,
Roger
Renew Membership, Subscription History, Manage Group Members - not sure how many others. Could be a generic issue as the headings would be H1 for menu items.
Thanks,
Roger
Please Log in or Create an account to join the conversation.
- Tuan Pham Ngoc
- Topic Author
- Offline
- Administrator
2 years 7 months ago #151585
by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic [22-March-2022] Membership Pro version 3.0.0 released
OK Roger. I see. I will work on this and update you when it is done. Should be easy
Tuan
Tuan
Please Log in or Create an account to join the conversation.
- Tuan Pham Ngoc
- Topic Author
- Offline
- Administrator
2 years 7 months ago #151603
by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic [22-March-2022] Membership Pro version 3.0.0 released
Hello Roger
I updated code to handle the case better. I decided that in case it is used in module, we won't display page heading because when it is needed, you can easily add it yourself (for example, when module is loaded in an article or a page using page builder extension)
So please download latest package from My Downloads section, upgrade it to your site and update us with the result
Regards,
Tuan
I updated code to handle the case better. I decided that in case it is used in module, we won't display page heading because when it is needed, you can easily add it yourself (for example, when module is loaded in an article or a page using page builder extension)
So please download latest package from My Downloads section, upgrade it to your site and update us with the result
Regards,
Tuan
Please Log in or Create an account to join the conversation.
- Tuan Pham Ngoc
- Topic Author
- Offline
- Administrator
2 years 7 months ago #151625
by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic [22-March-2022] Membership Pro version 3.0.0 released
Hi again Roger
I changed my mind again. In case the view is displayed using View module, we will use h2 tag instead h1 tag as you suggested before, not hiding it as it could cause unexpected behavior
You can download latest package of Membership Pro from my Downloads section, upgrade it to your site and it will work as expected
Regards,
Tuan
I changed my mind again. In case the view is displayed using View module, we will use h2 tag instead h1 tag as you suggested before, not hiding it as it could cause unexpected behavior
You can download latest package of Membership Pro from my Downloads section, upgrade it to your site and it will work as expected
Regards,
Tuan
Please Log in or Create an account to join the conversation.
- Roger Clarke
- Offline
- Premium Member
Less
More
- Posts: 88
- Thank you received: 1
2 years 7 months ago #151636
by Roger Clarke
Replied by Roger Clarke on topic [22-March-2022] Membership Pro version 3.0.0 released
Hi Tuan,
I've just downloaded and updated a dev site. Looks like no headings on the module - also looks like no headings on the menu item component views, so not sure I've got your latest version.
Either h2 or no heading works for me - no heading gives flexibility to use module advanced header tag option to set the header level, but I can see why it might cause problems to some to remove the header now.
Regards,
Roger
I've just downloaded and updated a dev site. Looks like no headings on the module - also looks like no headings on the menu item component views, so not sure I've got your latest version.
Either h2 or no heading works for me - no heading gives flexibility to use module advanced header tag option to set the header level, but I can see why it might cause problems to some to remove the header now.
Regards,
Roger
Please Log in or Create an account to join the conversation.
- Tuan Pham Ngoc
- Topic Author
- Offline
- Administrator
2 years 7 months ago #151637
by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic [22-March-2022] Membership Pro version 3.0.0 released
Hello Roger
That's strange to me. Maybe it is because it is associated with a menu item with Show Page Heading parameter set to No ?
That's strange to me. Maybe it is because it is associated with a menu item with Show Page Heading parameter set to No ?
Please Log in or Create an account to join the conversation.
- Roger Clarke
- Offline
- Premium Member
Less
More
- Posts: 88
- Thank you received: 1
2 years 7 months ago #151639
by Roger Clarke
Replied by Roger Clarke on topic [22-March-2022] Membership Pro version 3.0.0 released
Ah, you are right, it was set to Global (No), though I haven't changed it since last week when I reported the h1/h2 issue!
All looks great now, thanks.
Roger
All looks great now, thanks.
Roger
Please Log in or Create an account to join the conversation.
- Tuan Pham Ngoc
- Topic Author
- Offline
- Administrator
2 years 7 months ago #151640
by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic [22-March-2022] Membership Pro version 3.0.0 released
Yes. I updated the code recently to inherit the settings from Menus when Menu Item has Show Page Heading set to Use Global.
It is exactly how Joomla core works, but I only implemented it recently
It is exactly how Joomla core works, but I only implemented it recently
Please Log in or Create an account to join the conversation.
Support
Documentation
Information
Copyright © 2024 Joomla Extensions by Joomdonation. All Rights Reserved.
joomdonation.com is not affiliated with or endorsed by the Joomla! Project or Open Source Matters.
The Joomla! name and logo is used under a limited license granted by Open Source Matters the trademark holder in the United States and other countries.
The Joomla! name and logo is used under a limited license granted by Open Source Matters the trademark holder in the United States and other countries.