don't to ignore read messages or messages seen !

  • vicky
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
10 years 1 month ago - 10 years 1 month ago #76293 by vicky
thanks a lot.
Last edit: 10 years 1 month ago by vicky.

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76299 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Confirming this one is a bug - fix is very simple
Thanks calum. I am going to review the fix and update it to the download package later today.

Regards,

Tuan
The following user(s) said Thank You: vicky

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76317 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Confirming this one is a bug - fix is very simple
Hi

I updated the download package with the fix (for both individual, group and shopping cart registration). You can access to my Downloads menu item download latest version and upgrade it to your site now (to fix the password issue)

For mini calendar (not really an issue), it is difficult and need more time. You might have to wait until Tuesday to have it, hope that won't cause you much trouble

Tuan

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago - 10 years 1 month ago #76322 by Roger D
Tuan,

Now the "username" is following the same required length as the password field. example: if you set password to 10 and enter a username that is 9 long, it will error and say say must be 10.

Also:
* Calendar Weeky Layout: Pressing Monthly View Button does NOT change to monthly view
To reproduce:(this had been fixed in EB 2.1.x)
- Create a New Menu Item: Menu Manager > Create: Menu Item Type > Calendar Weekly Layout
- Open this new menu item, it defaults to events in Weekly View (weekly view tab is active by default)
- Now press the Monthly View tab, It is not changing to monthly view

* Thumbnail image pops up in modal box (you had removed the modal box in EB 2.1.x)

Roger
Last edit: 10 years 1 month ago by Roger D.

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago - 10 years 1 month ago #76324 by Calum
Sorry should have spotted that when I fixed password.

It's using the same min length setting on both. I'm on phone with no PC so not easy to fix but if you go to line 140 of
com_eventbooking/site/view/register/tmpl/default.php

You should see <?php echo $minLength; about halfway along the line. Make it say <?php echo 'minSize[4]';

That's a dirty fix but will restore username to Min 4 chars.

Taun commented to fixing for group and individual and cart - not sure if that was 3 fixes or 1 fix for all.
Last edit: 10 years 1 month ago by Calum.

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76326 by Roger D
He changed a number of files, probably best for us to let him update the package. But, thank you for the info.

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76337 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic don't to ignore read messages or messages seen !
Hi

1. The username length issue, actually, it was there from earlier version. Infact, Joomla has no requirement for username length, so I just remove length requirement for username.

2. For the thumbnail popup, I restored the behavior. It is logic since when someone click on the thumbnail, they will see the large image (which admin uploaded)

3. For weekly calendar, I am going to check it later, maybe in the next two days as I just come back from a long holiday, and have so many support requests in queue (although I have been trying to work on it during the holiday, too, but I didn't have enough time to complete)

Tuan

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76341 by Roger D
Hi Tuan,

Thank you for the update. One small hiccup, Joomla 3.4.8 is requiring a 2 character minimum username. If registering through EB now and only enter 1 character username EB accepts, but that user is not added to Joomla user base (probably because it didn't meet the 2 character requirement?) I don't know when Joomla started the 2 limit, on my Joomla 2.5 site you are absolutely correct about no length requirement, maybe just code it for min 2 to match current joomla?

Hope you had great holiday and thank you,
Roger

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76346 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic don't to ignore read messages or messages seen !
Yes. I just checked and see that it is hardcoded in core code ( github.com/joomla/joomla-cms/blob/stagin.../table/user.php#L190 ), so I updated the download package to require 2 characters for username, too

You can download it again and upgrade it to your site

Regards,

Tuan
The following user(s) said Thank You: Roger D

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76364 by Roger D
Works perfectly now, thank you.

Please Log in or Create an account to join the conversation.

Moderators: Tuan Pham Ngoc