How to change months to month

  • Eoin Feeney
  • Topic Author
  • Offline
  • Senior Member
  • Senior Member
More
6 years 10 months ago #114839 by Eoin Feeney
How to change months to month was created by Eoin Feeney
My membership option is monthly. But it currently says "£30 /months"

This is poor English as it should be month for single items and months/days/years for anything > 1.

Is there a way to change this?

Also I have some suggestions for the language strings, can I submit these somewhere?

Please Log in or Create an account to join the conversation.

More
6 years 10 months ago #114842 by PhoenixUK
Replied by PhoenixUK on topic How to change months to month

Eoin Feeney wrote: My membership option is monthly. But it currently says "£30 /months"

This is poor English as it should be month for single items and months/days/years for anything > 1.

Is there a way to change this?

Also I have some suggestions for the language strings, can I submit these somewhere?


There is some incorrect English within MembershipPro Eoin but in all fairness, it's quite good as OS Solutions are based in Vietnam I believe. (Tuan who develops MembershipPro for OS Solutions will no doubt state if this is correct or not)

I've utilised Joomla's in-built 'Extension > Languages > Overrides' on a number of things, to get the English phrasing just right for my site. I'm sure that could work for you too.

Please Log in or Create an account to join the conversation.

  • Eoin Feeney
  • Topic Author
  • Offline
  • Senior Member
  • Senior Member
More
6 years 10 months ago #114843 by Eoin Feeney
Replied by Eoin Feeney on topic How to change months to month
Yes, that's what I'll do, but in this month vs months case I wasn't sure if that was something that should be coded instead.

The other overrides I can use but I'd like to submit them so Tuan and his team can enhance their hard work with good English too :) I know it's not their first tongue but I thought it would look more professional for my end users and I thought I'd try to give back to the community.

Please Log in or Create an account to join the conversation.

More
6 years 10 months ago #114844 by PhoenixUK
Replied by PhoenixUK on topic How to change months to month
Can't grumble with that Eoin. :)

Please Log in or Create an account to join the conversation.

More
6 years 10 months ago #114854 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic How to change months to month
Yes, I'm from Vietnam but I understand that English mistakes and it should be corrected

Could you please send me a screenshot of that page so that I can find the related code and correct it?

Regards,

Tuan

Please Log in or Create an account to join the conversation.

  • Eoin Feeney
  • Topic Author
  • Offline
  • Senior Member
  • Senior Member
More
6 years 10 months ago - 6 years 10 months ago #114859 by Eoin Feeney
Replied by Eoin Feeney on topic How to change months to month
I'll be honest, there's a lot there so I went through the first one quite detailed and then slowed down but did a find and replace on a few common ones. If anyone else wants to have a go at looking at them and seeing if they can catch anything I missed that would be great.

If not, at least it is an improvement for now. Hope it helps. See attached Zip file for the language strings. I just copied the whole file to an override and worked on it.
Attachments:
Last edit: 6 years 10 months ago by Eoin Feeney.

Please Log in or Create an account to join the conversation.

More
6 years 10 months ago #114865 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic How to change months to month
Replace language items might not be the right way. The point here is that if subscription length is greater than 1, we should say months like 2 months, 3 months

However, if subscription length is 1, we should keep the text Month

So I just want to know the pages (screenshot) you have this issue so that I can check the code

Regards,

Tuan

Please Log in or Create an account to join the conversation.

More
6 years 10 months ago - 6 years 10 months ago #115023 by Stefan Poensgen
Replied by Stefan Poensgen on topic How to change months to month
I don't know where you got this mistake, but i found one in
\components\com_osmembership\view\common\tmpl\pricingtable_circle_plans.php

Line 136
Change
Code:
$subscriptionLengthText = $item->subscription_length > 1 ? $item->subscription_length . ' ' . JText::_('OSM_MONTHS') : JText::_('OSM_MONTHS');
To
Code:
$subscriptionLengthText = $item->subscription_length > 1 ? $item->subscription_length . ' ' . JText::_('OSM_MONTHS') : JText::_('OSM_MONTH');
Last edit: 6 years 10 months ago by Stefan Poensgen.

Please Log in or Create an account to join the conversation.

More
6 years 10 months ago #115031 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic How to change months to month
Thanks Stefan. I confirmed and fixed it, also found it on one more files, too. I will check it on tomorrow to see whether there are other files with this issue and fix it all

Many thanks for pointing out

Tuan

Please Log in or Create an account to join the conversation.