Recurring Events - creates events with bad data

  • lkende
  • Topic Author
  • Offline
  • New Member
  • New Member
More
Recurring Events - creates events with bad data - Joom Donation - Joomla Extensions by Joomdonation
Need help with Joomla? We are available for hire to help with Joomla customization, upgrades, maintenance, and custom development.
Explore our services
15 years 11 months ago #6279 by lkende
Just bought and installed this component. Very nice so far!

When creating my first test event, I choose repeat task once a week and set recurring end date. It then generates an event for each date, but uses the recurring end date as the event end date for all events including the parent, and it loses the specific times for the event, setting them all to 12am. It also only sets the category for the first and last event, all the middle ones have no category.

I could probably go in and tweak this, but was wondering if you are aware of the bug? I have attached a screenshot of my exact screen when creating a new entry before hitting save.

Thanks,

Luke
More
15 years 11 months ago #6386 by strullinger
Replied by strullinger on topic Re: Recurring Events - creates events with bad data
I am getting the same date / time bug, but I am not getting the catagory bug

Please Log in or Create an account to join the conversation.

More
15 years 11 months ago #6389 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Re: Recurring Events - creates events with bad data
Hi

This issue was fixed in the latest build of the extension on server. To fix this issue, please get this file, unzip it and upload it to administrator/components/com_eventbooking/models folder of your site .

Thanks,

Tuan

Attachment event.zip not found

More
15 years 10 months ago #6428 by jeff@marymoor.com
Replied by jeff@marymoor.com on topic Re: Recurring Events - creates events with bad data
I was having the same problem and this update didn't fix it.

I'm running v 1.2.2.

Please Log in or Create an account to join the conversation.

  • lkende
  • Topic Author
  • Offline
  • New Member
  • New Member
More
15 years 10 months ago - 15 years 10 months ago #6474 by lkende
Ok, I tested the update you provided, which was just to replace event.php in the specified directory.

This corrected the category and the event end times (not the date). However, all repeating events have an end date of the last reoccurring instance. Also, the start time minutes are lost.

I looked through the code and see some mistakes. Firstly, the helper.php defines getting reoccurring dates, which is using this function call:

$eventDates[] = strftime('%Y-%m-%d %H:%I:%S', $nextEventDate) ;

The %I is for an hour format not for minutes, so I changed this to

$eventDates[] = strftime('%Y-%m-%d %H:%M:%S', $nextEventDate) ;

for each case in the helper file... that fixed it losing the start date minutes.

Now, as far the end time, your logic uses the sames event_end_date for every event. This does not work as expected. If I have set up an event say for 01-04-2011 from 2:30pm to 5:30pm, and then repeat it once a week until the end of January, then I would expect that the event created on 01-11-2011 would start and end on 01-11-2011, but instead it ends on 01-25-2011 which is the last end date of all repeating event dates. All event dates get set to this 01-25-2011, which when I look in the code, you set the event end date to the last date in all repeating event dates.

Instead, as Im sure you will see, the code should determine the duration of the event , in my case, three hours, and then set the end date for each event by adding the duration back to the start date.

Here's what I did to the event.php file:

added $eventDuration = abs(strtotime($row->event_date) - strtotime($row->event_end_date)); at line 219
commented out $row->event_end_date = JHTML::_('date',.... ;
changed the child events to have this line as determining end date:
$rowChildEvent->event_end_date = strftime('%Y-%m-%d %H:%M:%S', strtotime($eventDates[$i]) + $eventDuration) ;

Now it behaves as expected. I will leave my changes in place for now. Let me know if you change this in your source files.

thanks
Last edit: 15 years 10 months ago by lkende.

Please Log in or Create an account to join the conversation.

More
15 years 10 months ago #6520 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Re: Recurring Events - creates events with bad data
Thanks lkende so much for contributing to fix this issue. I have applied the fix to version 1.3.0 (which will be released later today). Everything is working properly now !


Thanks again,

Tuan

Please Log in or Create an account to join the conversation.

  • Sirius Technologies
  • Offline
  • New Member
  • New Member
More
12 years 6 months ago #44318 by Sirius Technologies
Replied by Sirius Technologies on topic Recurring Events - creates events with bad data
Hi,

I am using Events Booking version 1.6.3 and I am still experiencing this bug.

Overriding the event.php is a bad idea since it was posted 3 years ago.

How to fix this? Settings screen shots is provide.

Thanks,


Please Log in or Create an account to join the conversation.

More
12 years 6 months ago #44336 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Recurring Events - creates events with bad data
Hi

Could you please let us know whether you see this bug when creating events from front-end or back-end of the site ? Please let us know so that we can check and get it sorted right away !

Tuan

Please Log in or Create an account to join the conversation.

  • Sirius Technologies
  • Offline
  • New Member
  • New Member
More
12 years 6 months ago #45081 by Sirius Technologies
Replied by Sirius Technologies on topic Recurring Events - creates events with bad data
Thanks Tuan,

We appreciate your response. We are very sorry for this, Recurring Events is working great. We just misunderstood the documentation.

Thanks!

Please Log in or Create an account to join the conversation.

More
12 years 6 months ago #45086 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Recurring Events - creates events with bad data
Great ! Thanks for confirming !

Tuan

Please Log in or Create an account to join the conversation.

Moderators: Tuan Pham Ngoc