CSS bug in mod_eb_events improved.css

James Riley
Topic Author
Offline
Platinum Member

More

9 years 1 week ago #96098 by James Riley

CSS bug in mod_eb_events improved.css was created by James Riley

Hi Tuan,

The following seems to be a bug in mod_eb_events -> improved.css . The second set of class* selectors should have the small.category and small.location appended, otherwise they become global and affect the entire page, not just the EB Events module.

Existing CSS:

Code:

small.category [class^="icon-"], [class*=" icon-"],
small.location [class^="icon-"], [class*=" icon-"]{
	font-size: 18px;
	position: relative;
	top: 3px;
}

Proper CSS:

Code:

small.category [class^="icon-"], small.category [class*=" icon-"],
small.location [class^="icon-"], small.location [class*=" icon-"]{
	font-size: 18px;
	position: relative;
	top: 3px;
}

James Riley .: EventBooking user since 2014 ::: JoomDonation user since 2016 :.
.: grfx & web design / IT / AV @ St. Therese Institute of Faith and Mission, Bruno, SK, Canada :.

Please Log in or Create an account to join the conversation.

Tuan Pham Ngoc
Away
Administrator

More

9 years 1 week ago #96110 by Tuan Pham Ngoc

Replied by Tuan Pham Ngoc on topic CSS bug in mod_eb_events improved.css

Thanks James. Could you please help making a PR directly on github? You know, you are much better with css than me

Regards,

Tuan

Please Log in or Create an account to join the conversation.

James Riley
Topic Author
Offline
Platinum Member

More

9 years 1 week ago #96203 by James Riley

Replied by James Riley on topic CSS bug in mod_eb_events improved.css

Looks like it was an old custom tweak that *I* added to my install, and I didn't write correctly as it is not in the repository code... plus, I didn't mark as an addition that I had made (I usually annotate my changes!), so I totally didn't realize that it was something that I added. I really need to start using GitHub for tracking, managing and merging changes that I make :whistle:

James Riley .: EventBooking user since 2014 ::: JoomDonation user since 2016 :.
.: grfx & web design / IT / AV @ St. Therese Institute of Faith and Mission, Bruno, SK, Canada :.

Please Log in or Create an account to join the conversation.

Tuan Pham Ngoc
Away
Administrator

More

9 years 1 week ago #96220 by Tuan Pham Ngoc

Replied by Tuan Pham Ngoc on topic CSS bug in mod_eb_events improved.css

Yes James. If you have custom installation, using github for managing it would be the right choice

Tuan

Please Log in or Create an account to join the conversation.

Moderators: Tuan Pham Ngoc

Powered by Kunena Forum

CSS bug in mod_eb_events improved.css

Support

Documentation

Information

Connect Us