Adding to ACY mailing list

  • Brian Lisle
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
9 years 10 months ago #74286 by Brian Lisle
Adding to ACY mailing list was created by Brian Lisle
I noticed that when someone registered and went to pay with paypal, they got added to the mailing list before the payment is complete. (One person went through the process but did not complete payment, but yet they got added to the mailing list.)
When does this function happen? Could it be set to only happen on completion of payment? Especially for offline payments. I don't want to send out emails to registrants on that list unless they've successfully paid.

Please Log in or Create an account to join the conversation.

More
9 years 10 months ago #74299 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Adding to ACY mailing list
You can edit the code to get it works like that:

1. Open the file plugins/eventbooking/acymailing/acymailing.php

2. Find this line of code:
Code:
public function onAfterStoreRegistrant($row)

3. Change it to:
Code:
public function onAfterPaymentSuccess($row)

After that, it should work as expected

Tuan

Please Log in or Create an account to join the conversation.

  • Brian Lisle
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
9 years 10 months ago #74310 by Brian Lisle
Replied by Brian Lisle on topic Adding to ACY mailing list
Thanks! Will this be a permanent change, or is it one I'll have to make every time I upgrade?

Please Log in or Create an account to join the conversation.

More
9 years 10 months ago #74317 by James Riley
Replied by James Riley on topic Adding to ACY mailing list
It would be a code change that you would have to maintain every time you upgrade. Unfortunately, it's not a file in a */template/ folder, otherwise you could create a template override that would be kept during upgrades.

After applying the changes, save a copy of your changed version (eg. plugins/eventbooking/acymailing/acymailing.modified.php ). When you upgrade EB, manually overwrite acymailing.php with acymailing.modified.php (I don't think the Devs change the coding of the acymailing plugin very often, so you shouldn't have to worry too much about breaking new features by overwriting with old code.) Just remember to do this every time you upgrade EB!! :)

James Riley .: EventBooking user since 2014 ::: JoomDonation user since 2016 :.
.: grfx & web design / IT / AV @ St. Therese Institute of Faith and Mission, Bruno, SK, Canada :.

Please Log in or Create an account to join the conversation.

  • Brian Lisle
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
9 years 10 months ago #74319 by Brian Lisle
Replied by Brian Lisle on topic Adding to ACY mailing list
Yes, I already have changes I make each time I upgrade, I am familiar with the process, thanks... I am hoping it would be a permanent change as I would think folks would only want to add someone to a mailing list if they have successfully paid for their event.

Please Log in or Create an account to join the conversation.

More
9 years 10 months ago #74320 by James Riley
Replied by James Riley on topic Adding to ACY mailing list
It certainly makes sense to me that you should only be added after being fully registered. Maybe the Devs would consider committing the change to the core release either as the new default or as an optional toggle?

James Riley .: EventBooking user since 2014 ::: JoomDonation user since 2016 :.
.: grfx & web design / IT / AV @ St. Therese Institute of Faith and Mission, Bruno, SK, Canada :.

Please Log in or Create an account to join the conversation.

More
9 years 10 months ago #74326 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Adding to ACY mailing list
OK. Will add it to core download package. It will be default behavior from version 2.3.1

Regards.

Tuan

Please Log in or Create an account to join the conversation.

More
9 years 10 months ago #74327 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Adding to ACY mailing list
Hmm. How about registrants choose offline payment for the registration ? We will only add him to mailing lists when the registration approved, too ?

Tuan

Please Log in or Create an account to join the conversation.

  • Brian Lisle
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
9 years 10 months ago #74342 by Brian Lisle
Replied by Brian Lisle on topic Adding to ACY mailing list
Yes, absolutely. Also, that should be when the invoice is created as I have the QRCODE in the invoice for admittance to the event.

Please Log in or Create an account to join the conversation.

Moderators: Tuan Pham Ngoc