Need help with Joomla? We are available for hire to help with Joomla customization, upgrades, maintenance, and custom development.
Explore our services
All questions about EDocman extension

Slow site: Documents module generating multiple iframes containing parent page

  • jd1980
  • Topic Author
  • Offline
  • New Member
  • New Member
More
2 weeks 6 days ago #179135 by jd1980
Hi,
I had an issue with one of my websites were the page load was slow on a page where I was using the Documents Module. I realised that this was because the module was placing iframes with src="#". Google Chrome loads a copy of the parent page into each of these iframes.

You can see the same happening on your Demo site on this page:  demo.joomdonation.com/edocman/

If you look at the Network tab in web inspector and filter to 'Doc' you'll see that it is loading up the page 9 times (once and then 8 times within iframes).

I have already fixed this issue on my own site  (by overriding all of the cases of src="#"  with src="about:blank" but I though I should mention the issue here in case you aren't aware of it.

Thanks for all your hard work and the recent security updates.

Please Log in or Create an account to join the conversation.

  • jd1980
  • Topic Author
  • Offline
  • New Member
  • New Member
More
2 weeks 6 days ago #179136 by jd1980
sorry i meant to post this in Edocman forum not presales.

Please Log in or Create an account to join the conversation.

  • Dang Thuc Dam
  • Away
  • Administrator
  • Administrator
More
2 weeks 6 days ago #179137 by Dang Thuc Dam
Hi,
Thank you for reporting this issue and for the detailed explanation.
I have made a small code change to improve the page loading speed on Chrome, especially in cases where the Documents Module is used.
Could you please test it again on the EDocman demo site and share your feedback?
Best regards,
Dam

Please Log in or Create an account to join the conversation.

  • jd1980
  • Topic Author
  • Offline
  • New Member
  • New Member
More
2 weeks 5 days ago #179157 by jd1980
Hi Dam,

Thanks for looking at this so quickly. Yes, changing them to src="about:blank" has solved the issue on your demo site. :-)
Will this be included in the next release (I am using overrides on those files at the moment)?

An even better and cleaner fix, when you have time, would be not to load the html for those iframes (and the 3 x associated js files for those modals) at all unless the configuration is set to use modals.

Many thanks,
Jen

Please Log in or Create an account to join the conversation.

  • Dang Thuc Dam
  • Away
  • Administrator
  • Administrator
More
2 weeks 5 days ago #179158 by Dang Thuc Dam
Hi Jen,
Thank you for confirming.
Yes, all of these changes will be included in the next release of EDocman.
If you need the updated files earlier, please submit a support ticket under the EDocman category, and I will send them to you.
Many thanks,
Dam

Please Log in or Create an account to join the conversation.

  • jd1980
  • Topic Author
  • Offline
  • New Member
  • New Member
More
2 weeks 4 days ago #179159 by jd1980
Thanks!

One more thing for this module... I noticed that the 'Number of Columns' option seems to be missing from the module edit form, although the code is there for it in the template.

It would be good to also make that columns css specific to the current module, as otherwise when you have more than one Documents module on the page with different number of columns it applies the same columns to all (the last one loaded)

Please Log in or Create an account to join the conversation.

  • Dang Thuc Dam
  • Away
  • Administrator
  • Administrator
More
2 weeks 4 days ago #179160 by Dang Thuc Dam
Hi,
Thank you for reporting this.
I can confirm that the Number of Columns parameter is currently missing from the EDocman Documents module parameters.
We will add this parameter back and include the update in the next release.
Many thanks,
Dam

Please Log in or Create an account to join the conversation.

Moderators: Dang Thuc Dam