error or intention?

  • reilldesign
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
3 years 8 months ago #148426 by reilldesign
error or intention? was created by reilldesign
when designing the sign-up.html page (aka register.php), i noticed that the h2 and h3 headers for a new registration are in the login form (default_login.php). See my screenshot.
In my opinion, however, this should be in the default_form.php. then it would be possible to design the two forms as grid blocks and display them in two columns.
is this intentional or a bug?

 

Please Log in or Create an account to join the conversation.

More
3 years 8 months ago #148440 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic error or intention?
It was there since the time we did not support columns layout. Since it is there always and people could override the layouts, I'm afraid of we won't be able to make any changes (to avoid break existing websites with override)

So if you want to change it, I guess you will have to override the layout for now

Regards,

Tuan

Please Log in or Create an account to join the conversation.

  • reilldesign
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
3 years 8 months ago #148452 by reilldesign
Replied by reilldesign on topic error or intention?
i have created overrides for both form templates default_login.php and default_form.php. from default_login.php i have removed the following code (screen default_login.png) and pasted it into default_form.php (screen default_form.png). the result looks great. are there any technical problems with this?

Please Log in or Create an account to join the conversation.

More
3 years 8 months ago #148453 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic error or intention?
There should not be any problem. Just please implement the change using override so that it won't be lost when you update to future releases of the extension in the future

Tuan

Please Log in or Create an account to join the conversation.

  • reilldesign
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
3 years 8 months ago #148454 by reilldesign
Replied by reilldesign on topic error or intention?
thank you for the assessment. i have included both files via override.

Please Log in or Create an account to join the conversation.

More
3 years 8 months ago #148459 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic error or intention?
Great :)

Please Log in or Create an account to join the conversation.