Subscription history - minor bug

  • Roger Clarke
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
6 years 6 months ago #118922 by Roger Clarke
Subscription history - minor bug was created by Roger Clarke
Hi,

I've just noticed a minor bug with the subscription history module - the invoice column th has class set to hidden-phone but the td doesn't, meaning the invoice column is displayed on a phone without the heading.

It would be nice to have a css id on each column so that I could use css to decide which columns to display on a smaller device.

Regards,
Roger

Please Log in or Create an account to join the conversation.

More
6 years 6 months ago #118933 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Subscription history - minor bug
Hi Roger

Thanks. I confirmed the issue and fixed it. Please access to My downloads menu item, download latest package, upgrade it to your site to have this small issue fixed

As for hide certain column, we don't need css class for each column. You can use nth-child() CSS pseudo-class developer.mozilla.org/en-US/docs/Web/CSS/:nth-child to hide any column you want

Tuan

Please Log in or Create an account to join the conversation.

  • Roger Clarke
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
6 years 6 months ago #119004 by Roger Clarke
Replied by Roger Clarke on topic Subscription history - minor bug
I've downloaded and installed the latest version but I'm afraid the th is still set to hidden-phone and the td is displayed.

Thanks for the suggestion with the CSS.

Please Log in or Create an account to join the conversation.

More
6 years 6 months ago #119013 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Subscription history - minor bug
Hi Roger

Could you please make a screenshot of the page? I want to make sure we are talking about the same page

Tuan

Please Log in or Create an account to join the conversation.

  • Roger Clarke
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
6 years 6 months ago #119017 by Roger Clarke
Replied by Roger Clarke on topic Subscription history - minor bug
Sure - screenshot attached and html copied below...

<form method="post" name="adminForm" id="adminForm" action="/~ukfa1501/component/osmembership/?view=subscriptions&amp;Itemid=">
<h1 class="osm-page-title">Subscription History</h1>
<table class="table table-striped table-bordered">
<thead>
<tr>
<th>
Membership Type </th>
<th class="center">
Joining Date </th>
<th class="center">
Active Time </th>
<th style="text-align: right;" class="hidden-phone">
Gross Amount </th>
<th class="hidden-phone">
Status </th>
<th class="hidden-phone">
Invoice Number </th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="/~ukfa1501/component/osmembership/subscription-detail?id=9&amp;Itemid=">UK Fire Association Full Membership</a>
</td>
<td class="center">
26th October 2018 </td>
<td class="center">
<strong>26th October 2018</strong> To <strong>
26th October 2019 </strong>
</td>
<td style="text-align: right;" class="hidden-phone">
£235.00 </td>
<td class="hidden-phone">
Active </td>
<td class="center">
<a href="/~ukfa1501/component/osmembership/?task=download_invoice&amp;id=9" title="Download">IV0001</a>
</td>
</tr>
</tbody>
</table>

</form>
Attachments:

Please Log in or Create an account to join the conversation.

More
6 years 6 months ago #119020 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Subscription history - minor bug
Checked the code again and could not see the issue, even tested on my computer

In this case, please submit a support ticket sending us:

1. Super admin account of your site

2. A subscriber account

3. Link to the page

We are going to check to see what's wrong and get it corrected for you. Maybe it causes by an override base on old version?

Tuan

Please Log in or Create an account to join the conversation.

  • Roger Clarke
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
6 years 6 months ago #119110 by Roger Clarke
Replied by Roger Clarke on topic Subscription history - minor bug
To hopefully save you some time I have looked at the code for it, in view/common/tmpl/subscriptions_history.php

<th class="<?php echo $hiddenPhoneClass; ?>" class="<?php echo $centerClass; ?>">

<td class="<?php echo $centerClass; ?>" class="hidden-phone">

As I'd like to display the invoice on a phone I have changed them to the following and it works:

<th class="<?php echo $centerClass; ?>">

<td class="<?php echo $centerClass; ?>">

Putting the hidden-phone within the same class attribute also works to hide it on a phone - not sure you can specify two separate class attributes.

Please Log in or Create an account to join the conversation.

More
6 years 6 months ago #119111 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Subscription history - minor bug
Hi Roger

That was a bug and I corrected it. For your information, here is the code from latest package

Tuan
Attachments:

Please Log in or Create an account to join the conversation.

  • Roger Clarke
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
6 years 6 months ago #119112 by Roger Clarke
Replied by Roger Clarke on topic Subscription history - minor bug
I've just downloaded the package for 2.16.0 again and it doesn't include your code change...

Please Log in or Create an account to join the conversation.

More
6 years 6 months ago #119119 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Subscription history - minor bug
Hmm

So strange to me. I just updated the package again. Could you please try to re-download and update?

Tuan

Please Log in or Create an account to join the conversation.