Subscription length

Annual subscriptions are in fact being generated as a year and a day, which I suggest is wrong.

I think you've coded to exclude the end date from a period, which is alright for individual subscriptions, but with automatically recurring subscriptions it starts to cause a problem.

For an annual subscription started on the 12 of April 2016 the end date is given as the 12th of April 2017, and when this is an automatically recurring subscription the automatically generated next subscription starts on the 13th of April 2017 and finishes on the 13th of April 2018. Next year it will drift a further day.

Membership Pro 2.8.3, Joomla 3.6

Hello Mark

The general rule is the start date of the new subscription record will be end date of the previous record + 1 day. I make it works like that to avoid users loosing one day of their subscription duration, remember that if they don't renew for example, they will have access to the end of that date

With that said, I don't see much problem with adding one day for a yearly subscription. If that's important to you, you can submit a support ticket, I can help editing the code so that one day is not being added to the renewal

Regards,

Tuan

But, by adding one day, ie making the subscription that started on (eg) the 12/4/16 end on the 12/4/17 including that day it isn't a one year subscription any more, it's a one year and one day subscription. Is that what you've done with the code? I thought you'd excluded the end date, and you could get the same effect by making the annual subscription the correct number of days (365 in a normal year) and including the end date, rather than one day too many (366) and excluding the day.

Why does it matter? Our site publishes magazines. If someone subscribes two days before the next issue is out they will (automatically) receive the last issue and then two days later the next issue. One the second automatic renewal suddenly they will miss an issue because the renewal date has been (incorrectly) pushed forward.

Guess it is OK to not add one day to the recurring subscription renewal, too. No one would complain about it (I can pay for one year subscription, so why I have to care about one day, LOL)

With that said, I will modify code to not adding one day to recurring subscription renewal and you would be fine. Something for the next minor release

Tuan