Incorrect label ID / Improvement suggestions

  • Quy Ton
  • Topic Author
  • Offline
  • Junior Member
  • Junior Member
More
2 years 9 months ago - 2 years 9 months ago #157041 by Quy Ton
Incorrect label ID:
Code:
<div class="control-group">     <div class="control-label">         <?php echo EventbookingHelperHtml::getFieldLabel('registrants_page_orientation', Text::_('EB_REGISTRANTS_EXPORT_PAGE_FORMAT')); ?>     </div>     <div class="controls">         <?php echo $this->lists['registrants_page_format']; ?>     </div> </div>


Maybe remove the title attribute as it provides no additional information.
 

Under Configuration, there are 226 instances of empty class="" attribute. Preferably don't output them.
 

Translation > Backend Language: One of the entries is causing the horizontal scrollbar. Also, for entries that are long, please consider displaying them as textarea.
 
 
Last edit: 2 years 9 months ago by Quy Ton.

Please Log in or Create an account to join the conversation.

More
2 years 9 months ago #157045 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Incorrect label ID / Improvement suggestions
Thanks Quy. Fixed most of them. For the translation, I don't have solution yet. So I will leave it as how it is for now. Also, I need to test some other changes which I made to the package, so this time, I don't have it updated to server yet.

Regards,

Tuan

Please Log in or Create an account to join the conversation.

Moderators: Tuan Pham Ngoc