Deposit System: Deposit Amount Field

  • Donal
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
6 years 10 months ago #117477 by Donal
Hi Tuan,

In previous versions of EB, when a user completed payment (having initially reserved with a deposit), the Deposit Amount Field and Due Amount Field were unmodified. This was incorrect, as there was actually nothing due anymore and if I manually resent a booking confirmation email, the email incorrectly stated that money was still due.

In this verion (3.7.1), after a user completes payment, both the Deposit Amount and Due Amount fields are cleared. This is incorrect also, as I now have 2 transaction IDs (Deposit & Completion), but no way of figuring our how much the initial deposit was, which means I have no way of knowing in EB export how much the completion payment was. This makes bookkeeping very difficult.

The correct way to handle this is to clear Due Amount field, but leave Deposit Amount field intact when a user completes payment.

In that way, we can match initial transaction ID with the Deposit Amount and completion transaction ID with Gross Amount - Deposit Amount.

Tuan, is this a "bug" you think you will fix? If not, or if the fix will take some time, can you please let me know which file I would need to modify so that Deposit Amount isn't cleared on completion payment?

Thanks,
Donal

Please Log in or Create an account to join the conversation.

  • Donal
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
6 years 9 months ago #117745 by Donal
Replied by Donal on topic Deposit System: Deposit Amount Field
Hi,

any thoughts on this, or any suggestions for the file I would need to edit so that the Deposit Amount isn't cleared on completion payment?

Thanks

Please Log in or Create an account to join the conversation.

More
6 years 9 months ago #117750 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Deposit System: Deposit Amount Field
Hello Donal

I missed your original post, sorry. In short, I don't think I changed something recently which could cause the deposit amount reset on payment completion

Could you please explain step by step how users make payment and cause this issue? Also, what payment method users use for make payment?

Tuan

Please Log in or Create an account to join the conversation.

  • Donal
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
6 years 9 months ago - 6 years 9 months ago #117752 by Donal
Replied by Donal on topic Deposit System: Deposit Amount Field
Hi Tuan,

I jumped from 3.1.3 to 3.7, so the change may have been made a while ago.

Users pay a deposit using Stripe. They then make payment via the completion payment link using Stripe.

Event is €144. Deposit is €36
After deposit, Deposit Amount Field is 36 and Due Amount Field is 108. Transaction_ID is the deposit stripe transaction ID. Deposit_Payment_Transaction_ID is null.
After completion, Deposit Amount and Due Amount are both cleared. Transaction_ID is the deposit stripe transaction ID. Deposit_Payment_Transaction_ID is the completion stripe transaction ID.

Should be:
After completion, Deposit Amount is €36. Due Amount is cleared. Transaction_ID is the deposit stripe transaction ID. Deposit_Payment_Transaction_ID is the completion stripe transaction ID.
Last edit: 6 years 9 months ago by Donal.

Please Log in or Create an account to join the conversation.

  • Donal
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
6 years 9 months ago #117893 by Donal
Replied by Donal on topic Deposit System: Deposit Amount Field
Hi Tuan,

sorry to put a bit of pressure on, but I'd really like to fix this. Can you let me know which file I need to edit, so that Deposit_Amount isn't cleared when a completion payment is made?

Regards,
Donal

Please Log in or Create an account to join the conversation.

More
6 years 9 months ago #117895 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Deposit System: Deposit Amount Field
Hi Donal

As of right now, I don't know which file causes that change as this is something I should not implement in my code. I will try to check it today, if the bug is valid, I will correct it and included in next release 3.8.0 (planned to be released on Monday next week if all is OK)

Tuan

Please Log in or Create an account to join the conversation.

More
6 years 9 months ago #117903 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Deposit System: Deposit Amount Field
Hello Donal

So I just tested it again (in the version which I am working on but I didn't make any changes to this feature) and could not see this issue

In this case, I guess you should wait for new version 3.8.0 which I will release on Monday, update and try again. If it still doesn't work, you can submit a support ticket telling me how I can see the problem myself. I will check and correct it

Tuan

Please Log in or Create an account to join the conversation.

  • Donal
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
6 years 9 months ago #117985 by Donal
Replied by Donal on topic Deposit System: Deposit Amount Field

Tuan Pham Ngoc wrote: Hello Donal

So I just tested it again (in the version which I am working on but I didn't make any changes to this feature) and could not see this issuen


Hi Tuan,

I have some more information for you. Sorry, I thought I was being clear in my initial descriptions, but just found out that I left off a key bit of information: My issue isn't that the Deposit Amount field is being cleared!! My issue is that the deposit amount field isn't being exported after somebody has paid their balance!!!

Sorry. :| I hope you can see the issue now.

Please Log in or Create an account to join the conversation.

More
6 years 9 months ago #117992 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Deposit System: Deposit Amount Field
Exported? In Registrants Export? If so, that's how it works at the moment and I don't know if we should change it

If you need that amount to be exported, submit a support ticket sending us super admin account of your site. We will modify code to show that amount for you. This modification will be implemented using override, so the change won't be lost when you update to future releases of the extension

Regards,

Tuan

Please Log in or Create an account to join the conversation.

  • Donal
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
6 years 9 months ago - 6 years 9 months ago #118001 by Donal
Replied by Donal on topic Deposit System: Deposit Amount Field
Yes, it's the registrant export I'm talking about.

Of course Deposit Amount needs to remain in the export. Without it, how is one supposed to do bank reconciliations for accounting?

It makes sense that you have cleared the due column from the export, but Deposit Amount needs to remain. Why do you think it needs to be blank?

I'm happy to try to make the change myself, if you tell me the file I need to modify.
Last edit: 6 years 9 months ago by Donal.

Please Log in or Create an account to join the conversation.

Moderators: Tuan Pham Ngoc