Bug in Event waiting list

  • Tim Stöhr
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
10 years 1 month ago #76082 by Tim Stöhr
Bug in Event waiting list was created by Tim Stöhr
Hey guys,

Hope you had a good TET.

I have an annoying Bug in the waiting list stuff. The [EVENT_LINK] that the website sends out does NOT work when I cancel peoples subscription on the backend (user cancellation over front-end seems to work).

Here is what I received when I canceled someones event attendance (Link does not work): http://munich.international-friends.netindex.php?option=com_eventbooking&view=event&id=216&catid=18&Itemid=1699

Here is what the link for front-end is: munich.international-friends.net/events/...ake-tax-declarations

Please Log in or Create an account to join the conversation.

  • Tim Stöhr
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
10 years 1 month ago - 10 years 1 month ago #76083 by Tim Stöhr
Replied by Tim Stöhr on topic Bug in Event waiting list
Found the bug.... It misses out one / after the .net and the index.php. How do I solve this?
Last edit: 10 years 1 month ago by Tim Stöhr.

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76091 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Bug in Event waiting list
Hi Tim

Still having the holiday now but I am now having more time to work than in the last 4 days. Could you please let me know step by step what I can do t see the error?

I will then check and solve it

Tuan

Please Log in or Create an account to join the conversation.

  • Tim Stöhr
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
10 years 1 month ago #76096 by Tim Stöhr
Replied by Tim Stöhr on topic Bug in Event waiting list
OK that one is easy...
(the problem is a missing / )

Here is for reproducing it:

_Create event and subscribe a couple of people to it. Including a couple in waiting list (ie the event is full).
_Go to back-end registrant management.
_Set one of the subscribed people FROM THE BACK-END to cancelled.
_It will send out the waiting list opportunity email to the people on the waiting list. The link in the email will be missing the / between the domain and the index.php.

Could you tell me which php file (and best, how) I should change? It is a simple spelling error as far as I can see.

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76099 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Bug in Event waiting list
Hi Tim

Try to look at the file components/com_eventbooking/helper/helper.php, method notifyWaitingList, you should see the code and can change it to meet your need. Then please report back what you changed, that would help saving me sometime

Regards,

Tuan

Please Log in or Create an account to join the conversation.

  • Tim Stöhr
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
10 years 1 month ago #76102 by Tim Stöhr
Replied by Tim Stöhr on topic Bug in Event waiting list
Euh... I am a biologist... No idea about php...

Just so that you can see the problem clearly. Look at this link taken out of a waiting list notification (yes it happens in all of them, this is just an example): http://munich.international-friends.netindex.php?option=com_eventbooking&view=event&id=216&catid=18&Itemid=1699

Locate the index.php in the link. There is a / missing in front of index.php.

The working link would be munich.international-friends.net/index.p...catid=18&Itemid=1699

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76130 by James Riley
Replied by James Riley on topic Bug in Event waiting list
Looking at the notifyWaitingList method Tuan mentioned, it uses JUri::getInstance()->toString to form the url.

My site was producing URLs with the same missing '/' while using the exact same JUri::getInstance()->toString command... because of a plugin conflict.

It would be a surprise if the problem was caused by the exact same broken third-party plugin... but stranger things have happened. @Tim, double check your plugins, and see if you have a MVC Override system plugin running, and disable it. It might shut down some custom code overrides make to otherwise un-overridable modules/components/etc. (check your template/YourTemplate/code folder (if it exists) to see if there is anything crucial being shutdown).

James Riley .: EventBooking user since 2014 ::: JoomDonation user since 2016 :.
.: grfx & web design / IT / AV @ St. Therese Institute of Faith and Mission, Bruno, SK, Canada :.

Please Log in or Create an account to join the conversation.

  • Tim Stöhr
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
10 years 1 month ago #76136 by Tim Stöhr
Replied by Tim Stöhr on topic Bug in Event waiting list
@James: Nope havent got that plugin. Also havent got the template/YourTemplate/code folder :(

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago - 10 years 1 month ago #76141 by James Riley
Replied by James Riley on topic Bug in Event waiting list
@Tim: Well, at least you know that it isn't that plugin causing an issue :) Only if you had that plugin would you have a /code folder.

Tuan should investigate further, but I think you should be able to get *your* site providing proper links by making the following change in components/com_eventbooking/helper/helper.php (warning -- I have not tested this modification, but I think it should do the trick for you. Make a copy of the original file so that. if it doesn't work, you can revert back).

Look for the two occurrences of JUri::getInstance()->toString(array('scheme', 'user', 'pass', 'host')) (lines 2488 and 2492 in my install).
Immediately after the [edit: SECOND occurrence of ] JUri::getInstance()->toString(array('scheme', 'user', 'pass', 'host')) and before the existing . (period), add
Code:
.'/'

In the end, you should have something that looks like: [edit Apply only after the SECOND (the else) occurrence ]


James Riley .: EventBooking user since 2014 ::: JoomDonation user since 2016 :.
.: grfx & web design / IT / AV @ St. Therese Institute of Faith and Mission, Bruno, SK, Canada :.
Last edit: 10 years 1 month ago by James Riley.

Please Log in or Create an account to join the conversation.

More
10 years 1 month ago #76142 by James Riley
Replied by James Riley on topic Bug in Event waiting list
Tuan will be able to confirm whether this is a bug that needs fixing the core package, or if it is just something that is happening on your site.

James Riley .: EventBooking user since 2014 ::: JoomDonation user since 2016 :.
.: grfx & web design / IT / AV @ St. Therese Institute of Faith and Mission, Bruno, SK, Canada :.

Please Log in or Create an account to join the conversation.

Moderators: Tuan Pham Ngoc