Mailchimp plugin bug

  • jd1980
  • Topic Author
  • Offline
  • New Member
  • New Member
More
2 months 1 week ago #169142 by jd1980
Mailchimp plugin bug was created by jd1980
Hi,

I found a bug with the Mailchimp plugin, where members renewing by Recurring PayPal subscriptions are being unsubscribed from the Mailchimp list.
I think it is due to the new subscription being created before the onMembershipExpire event is triggered.

I had a look at the Acymailing plugin and found that the code to avoid this happening exist in that plugin:
Code:
// He renewed his subscription before, so don't remove him from the lists if (in_array($row->plan_id, $activePlans)) { return; }

This check needs adding to the Mailchimp Plugin (I have done it myself for now), below the line:
Code:
$activePlans = OSMembershipHelperSubscription::getActiveMembershipPlans($row->user_id, [$row->id]);

Thank you as always for the great extensions! :-)

Jen

Please Log in or Create an account to join the conversation.

More
2 months 1 week ago #169143 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Mailchimp plugin bug
Thanks Jen. Makes sense. Thanks for sharing. I fixed it and updated download package on server with this fix. So you do not have to worry about it when updating to future releases of the extension

Regards,

Tuan

Please Log in or Create an account to join the conversation.

  • jd1980
  • Topic Author
  • Offline
  • New Member
  • New Member
More
2 months 1 week ago #169144 by jd1980
Replied by jd1980 on topic Mailchimp plugin bug
Great, thanks! :-)

Please Log in or Create an account to join the conversation.

More
2 months 1 week ago #169145 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Mailchimp plugin bug
You're welcome. Thanks again for reporting the issue and proposed the solution

Regards,

Tuan

Please Log in or Create an account to join the conversation.

  • jd1980
  • Topic Author
  • Offline
  • New Member
  • New Member
More
2 weeks 10 hours ago #170066 by jd1980
Replied by jd1980 on topic Mailchimp plugin bug
Unfortunately, I have been having another look at this and found that my 'fix' did not solve the issue - it is still happening for recurring renewals via the os_paypal plugin.

I wonder whether the onMembershipExpire function is being called first, so the member is being deleted (archived) from mailchimp, but then is not being unarchived by the $mailchimp->post("lists/$listId/members", $data); that happens when the subscription is renewed.

Jen

Please Log in or Create an account to join the conversation.