Invoice - incorrect description for renewal

  • Brian Lisle
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
10 years 7 months ago #49297 by Brian Lisle
Invoice - incorrect description for renewal was created by Brian Lisle
Hi Tuan - In testing, I noticed that after doing a renewal, the invoice seems to list the text contained in OSM_PAYMENT_FOR_UPGRADE_SUBSCRIPTION and not OSM_PAYMENT_FOR_RENEW_SUBSCRIPTION as I would think it would. Could you check on that please?
Thanks!

Please Log in or Create an account to join the conversation.

More
10 years 7 months ago #49315 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Invoice - incorrect description for renewal
Hi Brian

Yes. I will check it. I am busy tonight and tomorrow morning to finish new version of one of my extension, so I will check it on tomorrow afternoon.

Regards,

Tuan

Please Log in or Create an account to join the conversation.

  • Brian Lisle
  • Topic Author
  • Offline
  • Premium Member
  • Premium Member
More
10 years 7 months ago #49509 by Brian Lisle
Replied by Brian Lisle on topic Invoice - incorrect description for renewal
Any update on this?

Please Log in or Create an account to join the conversation.

More
10 years 7 months ago #49523 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Invoice - incorrect description for renewal
Sorry Brian. Working on some small improvements to Membership Pro at the moment and will check this issue on tomorrow morning

Tuan

Please Log in or Create an account to join the conversation.

More
10 years 3 months ago #55190 by Jim
I have the same problem, was there a fix for this?
Thanks Jim

Please Log in or Create an account to join the conversation.

More
10 years 3 months ago #55208 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Invoice - incorrect description for renewal
Hi Jim

Sorry, I forgot to check it. I just checked it by now and confirm the issue. It is now fixed on the latest codebase of the extension and will be in available in 1.6.8 release (I still want to work on few other things before making it public release).

For now, please follow the instruction below to get it fixed:

1. Open the file components/com_osmembership/helper/helper.php

2. Find the function generateInvoicePDF

3. Inside that function, find the code:
Code:
case 'renew': $itemName = JText::_('OSM_PAYMENT_FOR_RENEW_SUBSCRIPTION'); $itemName = str_replace('[PLAN_TITLE]', $rowPlan->title, $itemName); case 'upgrade':

Change it to:
Code:
case 'renew': $itemName = JText::_('OSM_PAYMENT_FOR_RENEW_SUBSCRIPTION'); $itemName = str_replace('[PLAN_TITLE]', $rowPlan->title, $itemName); break; case 'upgrade':

After that, the issue will be sorted

Tuan

Please Log in or Create an account to join the conversation.