- Posts: 35
- Thank you received: 0
Joomdonation Feedback and notes
- Jason Landau
- Topic Author
- Offline
- Junior Member
Less
More
7 years 8 months ago #96894
by Jason Landau
Joomdonation Feedback and notes was created by Jason Landau
Hi I just wanted to give some feedback and ask a little help if you're up for it.
I don't really think that using the language file for all titles is a great approach, no offense. It looks weird unless everything really has the same title.
First Idea**************
components/com_jdonation/view/campaigns/tmpl/default.php
I think it would be great if you could include the page title set by the menu. I did this which is rough...
$menu = &JSite::getMenu();
$active = $menu->getActive();
$menuname = $active->params->get('page_heading');
<h1 class="page-title"><?php echo $menuname; ?></h1>
Second Idea**********************
Same thing. Title should be the name of the campaign. You use it in the file so it was easy to find.
components/com_jdonation/view/donation/tmpl/default.php
<h1 class="jd-page-title"><?php echo $this->campaign->title ?></h1>
IMHO those would be improvements for all users and I don't really see a downside but maybe there's something I don't know.
Thank you for the great software!
I don't really think that using the language file for all titles is a great approach, no offense. It looks weird unless everything really has the same title.
First Idea**************
components/com_jdonation/view/campaigns/tmpl/default.php
I think it would be great if you could include the page title set by the menu. I did this which is rough...
$menu = &JSite::getMenu();
$active = $menu->getActive();
$menuname = $active->params->get('page_heading');
<h1 class="page-title"><?php echo $menuname; ?></h1>
Second Idea**********************
Same thing. Title should be the name of the campaign. You use it in the file so it was easy to find.
components/com_jdonation/view/donation/tmpl/default.php
<h1 class="jd-page-title"><?php echo $this->campaign->title ?></h1>
IMHO those would be improvements for all users and I don't really see a downside but maybe there's something I don't know.
Thank you for the great software!
Please Log in or Create an account to join the conversation.
- Mr. Dam
- Offline
- Administrator
Less
More
- Posts: 12826
- Thank you received: 1660
7 years 8 months ago #97314
by Mr. Dam
Replied by Mr. Dam on topic Joomdonation Feedback and notes
Hi Jason,
Thank you for your idea, i will make this change for next Joom Donation version
Regards,
Dam
Thank you for your idea, i will make this change for next Joom Donation version
Regards,
Dam
Please Log in or Create an account to join the conversation.
Moderators: Mr. Dam, Dũng Nguyễn Việt
Support
Documentation
Information
Copyright © 2024 Joomla Extensions by Joomdonation. All Rights Reserved.
joomdonation.com is not affiliated with or endorsed by the Joomla! Project or Open Source Matters.
The Joomla! name and logo is used under a limited license granted by Open Source Matters the trademark holder in the United States and other countries.
The Joomla! name and logo is used under a limited license granted by Open Source Matters the trademark holder in the United States and other countries.