Bug Report: Can not install Events Booking Theme

Events Booking 5.0.0
Joomla 5.1.4

There's no guidance on the docs.joomdonation.com/eventsbooking/deve...ion/customize-layout as to how to create a Theme for Event Booking.

Based on your other extensions, I've tried to follow the same process used for EShop theme:

• Copied the default template
• Renamed default.xml to install.xml in the base folder for the new theme (Had tried templatename.xml, but \administrator\components\com_eventbooking\model\theme.php at line 107 specifies it should be install.xml)
• Extended the list of folders to include all the theme folders available (which is not a complete list in default.xml - that needs reviewing)

So then I've packed up the new template folder as a zip containing:

• Folders per default theme structure
• install.xml

I've then gone to Events Booking > Dashboard > Setup > Themes and tried installing the theme package I've created.

That's when I get the errors occurring:

• Code:

  Call to a member function getName() on bool
• Turning debug on the error occurs at:
  Code:

  JROOT/administrator/components/com_eventbooking/model/theme.php:107
• Looking at theme.php at line 107 - the issue is that $root->getName() is returning a value that is incompatible:
  Code:

          $file = $xmlFiles[0];         $root = simplexml_load_file($file);         if ($root->getName() != 'install')         {             throw new Exception(Text::_('Invalid xml file for theme installation'));         }
• When I tried the installer with the templatename.xml, it returned the exception "Invalid xml file for theme installation", so it's only when the install.xml is correctly named that the function fails.

I've done all I can to diagnose the problem to get to a point where I can install the theme, but nothing has worked. I commented out the IF statement from 107-110 and then it threw another error with lines 112-115. That then partially installed the theme before crashing at Line 177. So I've now given up.

Please...

• Document the process to create an Event Booking theme so developers can build their own themes and not just rely on Joomla Template Overrides
• Check what your documentation describes actually works - fix theme.php if there's an issue when you test it.

The main reason I'm wanting to do it this way is that I'm creating a customised events booking theme that is better formatted for use with Yootheme Pro + my client's specific needs. That then has a replication effect as the changes I'm putting in apply across a number of customers that are all in a similar sector.


 

Hi Patrick

Please use the attached file as a sample structure theme and let us know if you have any questions about it

Regards,

Tuan

The Green theme has helped a little.

XML problem was a syntax error - I had HTML in the description. Wrapping it in <![CDATA[ ]]> has now moved the process along.

So next:

• The green template is overly simple. It has just the one layout for the events view - that's about as simple as you can get.
• I want to install a full replacement theme.
  • defaulttest.zip is a copy of the default theme, with all the default files, and an updated defaulttest.xml that has the name of the template changed, along with adding all the folders to be installed from the Zip.
  • In trying to install that version now where there's more files, I now get:
    Code:

    count(): Argument #1 ($value) must be of type Countable|array, null given
  • That error is from:
    Code:

    JROOT/administrator/components/com_eventbooking/model/theme.php:179
  • Line 179 is trying to loop through the files an it returns null causing the error.
    Code:

    for ($i = 0, $n = count($files); $i < $n; $i++)

Back to you to try what I've attached here now.

 
Hello

1. Please use the new attached package. It worked OK for me (I had to remove _notes folder from there, it contains an XML file and it is wrongly detected by the installation code)

2. But please do not put every layout into your theme. You should only add the layout you want to override into your custom themes. When the system looks for one layout , it will try:

- Find the layout from active theme
- If not found, then the layout from default theme will be used

If you add all layouts to your custom theme, you will loose any changes/bugs fixes we implement to default themes in future. So as I said, please put the layout you want to modify into your own theme

Hope my explanation are clear to you

Regards,

Tuan