Social button for Linkedin

  • hide10
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
2 years 2 months ago - 2 years 2 months ago #156324 by hide10
Social button for Linkedin was created by hide10
Hello,

The social buttons for Linkedin are not displaying properly, so I looked into the cause and found a mistake in the source.

in components/com_eventbooking/themes/default/event/default_social_buttons.php (line 57),
Code:
<i class="fa fab fa-linkedin-square"></i> 
should be
Code:
<i class="fa fab fa-linkedin"></i> 

Hopefully this will be fixed in the next release.


Thanks!


Reference:
fontawesome.com/v5/icons/linkedin?s=solid&f=brands
fontawesome.com/v5/icons/linkedin-in?s=solid&f=brands
Last edit: 2 years 2 months ago by hide10. Reason: add Reference

Please Log in or Create an account to join the conversation.

  • hide10
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
2 years 2 months ago #156338 by hide10
Replied by hide10 on topic Social button for Linkedin
I updated Events Booking to the latest version this afternoon. And I had to modify default_social_buttons.php again.

Please check the Reference link in my post and modify the file.

Please Log in or Create an account to join the conversation.

More
2 years 2 months ago #156340 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Social button for Linkedin
Hmm

Not sure what would happens if someone uses font-awesome 4 ? I will have to check it more

Tuan

Please Log in or Create an account to join the conversation.

  • hide10
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
2 years 2 months ago #156348 by hide10
Replied by hide10 on topic Social button for Linkedin
Yes, your source is the way Font Awesome 4 is written, which is different from Font Awesome 5.
fontawesome.com/v4/icon/linkedin-square
fontawesome.com/v5/icons/linkedin?s=solid&f=brands

For my site, the following CSS is applied in joomla-fontawesome.min.css.
Code:
.fab, .icon-joomla {     font-family: Font Awesome\ 5 Brands;     font-weight: 400 }

Font Awesome is tricky because the code is different between v4 and v5.

Please Log in or Create an account to join the conversation.

More
2 years 2 months ago #156349 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Social button for Linkedin
Yes. Sometime support different Joomla version, different frontend framework... is hard. For now, please the change you need. In near future, I will make it possible to handle css class mapping. So if you want to change fa-linkedin-square to fa-linkedin, just add a mapping for it.

It is doable. Just take sometime to implement and it will help the extension compatible better with other css frameworks when it is needed

Tuan
The following user(s) said Thank You: hide10

Please Log in or Create an account to join the conversation.

More
2 years 2 months ago #156510 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Social button for Linkedin
Just updated code in the extension to make it is possible to change these css class. Please download latest package from My Downloads section, upgrade it to your site

Then go to Events Booking -> Configuration, look at CSS Class Mapping tab, setup a class mapping like this:

fa fab fa-linkedin-square (Old CSS Class)
fa fab fa-linkedin (New Css Class)

Then it will work as expected. No need for modifying code or implement override

Regards,

Tuan

Please Log in or Create an account to join the conversation.

  • hide10
  • Topic Author
  • Offline
  • Elite Member
  • Elite Member
More
2 years 2 months ago #156515 by hide10
Replied by hide10 on topic Social button for Linkedin
Tuan, you are awesome!
The CSS Class Mapping is a good mechanism. It worked as expected!!

​​​​​​​

Please Log in or Create an account to join the conversation.

More
2 years 2 months ago #156516 by Tuan Pham Ngoc
Replied by Tuan Pham Ngoc on topic Social button for Linkedin
Yes. It helps when a site uses none supported Css framework. In this case, they can map the css class from their template with the css class use in the extension so that the layout looks consistent. A small improvement, but could be useful in some cases
The following user(s) said Thank You: hide10

Please Log in or Create an account to join the conversation.

Moderators: Tuan Pham Ngoc